fix(list): RemoveItem correctly removes item when filtering
#638
Conversation
- Added in a fix that allows the correct item to be removed when the list is being filtered - Previously, when it was in the `filtering state` and the `RemoveItem` method was called, it would remove the item from the `filteredItems` based on the index, however it would use the same index and remove from `unfiltered items` too, which is inconsistent since the index associated to the `filteredItems` may not be the same as the index of the `unfiltered items` - Hence to fix this, when it is in the `filtering state` and the `RemoveItem` method is called, it retrieves the index index of the `unfiltered items` that's available in the `filteredItems` and then correctly removes the item from `filteredItems` and `unfiltered items`
|
Thanks, @prithvijj. Do you mind adding some code to help illustrate what's being fixed? |
Hey @meowgorithm , kept it in draft, since I'm like adding testing notes as I type :) Shall request a review here and in the discord when it's ready! |
|
Sounds good; here is fine. Keep in mind that we have a lot of inbound PRs and issues and it may take a moment to get this one as we manage intake — however example codes definitely helps expedite the process. |
Yepp, aware of all the inbound pending PRs PR is ready now, so feel free to check it out whenever convenient |
Changes
filtering stateand theRemoveItemmethod was called, it would remove the item from thefilteredItemsbased on the index, however it would use the same index and remove fromunfiltered itemstoo, which is inconsistent since the index associated to thefilteredItemsmay not be the same as the index of theunfiltered itemsfiltering stateand theRemoveItemmethod is called, it retrieves the index index of theunfiltered itemsthat's available in thefilteredItemsand then correctly removes the item fromfilteredItemsandunfiltered itemsTesting Notes
exampledirconst numItems = 24toconst numItems = 5r.shuffle.Do()methodcd example; go run *.goPreviously
Regular view
Press
/and Filter forbananasPress
xShows that
Artichokewas removed, andbananaswasn'tNow
Regular view
Press
/and Filter forbananasPress
xShows that
bananaswas removed, which is expectedOther Notes
Related to #632