Problems rendering Task after code refactoring.

[zerovirus123]

I looked through the codebase for the CLI Kanban tutorial and decided to refactor the source files by moving them to separate directories (typedef.go goes to /typedef, task.go goes to /task, etc).

I moved task.go to the task package.

├── datastore.go
├── form
├── form.go
├── go.mod
├── go.sum
├── main.go
├── model.go
├── README.md
├── storage.json
├── styling.go
├── task
│   └── task.go
└── typedef
    └── typedef.go

In model.go, Task struct creation in initList() are refactored to task.go.

// model.go

func (m *Model) initLists(width, height int) {

    // original task creation code
    for _, value := range columns.Todo {
		task := Task{status: typedef.Todo, title: value.Title, description: value.Description}
		todoItems = append(todoItems, task)
    }

   // task creation post refactoring
   for _, value := range columns.Todo {
		task := task.NewTask(typedef.Todo, value.Title, value.Description)
		todoItems = append(todoItems, task)
   }
}

// task/task.go

func NewTask(status typedef.Status, title string, description string) Task {
	return Task{status: status, title: title, description: description}
}

After the changes, the Tasks within the columns could not be rendered properly.

How does BubbleTea render the Task structs? Does it matter if tasks are created in another package, rather than in the main package?

[bashbunni]

Hey @zerovirus123 do you mind pushing the latest changes to your cli_kanban repo so I can reproduce the issue? I tried cloning your repo and running it, but it's not giving me the error you're describing. Let me know when this is done and I'll check again!

[zerovirus123]

Hi @bashbunni, I just pushed the latest version to my repo. Sorry for the delay.

[bashbunni]

Ah so the issue is just that you renamed the Title and Description methods which actually need to keep their method signature to implement the DefaultItem interface. Check out this portion to see what I'm talking about:

bubbles/list/defaultitem.go

Line 64 in cd2593c

// DefaultItem describes an items designed to work with DefaultDelegate.

I've also attached the git diff of my changes to get it running. (Might also include some minor formatting changes from my Go formatter)

diff.txt

[bashbunni]

Let me know if it's more readable for me to PR the changes - totally up to you. I've got the working version on my machine 😄

[zerovirus123]

Hi, could you please submit a PR? That would be more readable. Thanks. Brian

…

On Wed, Oct 19, 2022 at 12:03 PM bashbunni ***@***.***> wrote: Let me know if it's more readable for me to PR the changes - totally up to you. I've got the working version on my machine 😄 — Reply to this email directly, view it on GitHub <#275 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACHXFN7DWBFUTMH4VW6JDM3WD56LFANCNFSM6AAAAAARHIRNUA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[bashbunni]

PR'd!