optimize parsing common timestamps #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlievieth
force-pushed
the
cev/parse-time
branch
from
8cf6002 to
aa086ca
Compare
This commit adds a dedicated function for parsing the two most common
timestamps used by sqlite3.
```
goos: darwin
goarch: arm64
pkg: github.com/charlievieth/go-sqlite3
cpu: Apple M4 Pro
│ base.10.txt │ new.10.txt │
│ sec/op │ sec/op vs base │
Suite/BenchmarkParseTime-14 11.347µ ± 0% 8.044µ ± 0% -29.11% (p=0.000 n=10)
│ base.10.txt │ new.10.txt │
│ B/op │ B/op vs base │
Suite/BenchmarkParseTime-14 1.713Ki ± 0% 1.713Ki ± 0% ~ (p=1.000 n=10) ¹
¹ all samples are equal
│ base.10.txt │ new.10.txt │
│ allocs/op │ allocs/op vs base │
Suite/BenchmarkParseTime-14 64.00 ± 0% 64.00 ± 0% ~ (p=1.000 n=10) ¹
¹ all samples are equal
```
timefmt benchmarks:
```
goos: darwin
goarch: arm64
pkg: github.com/charlievieth/go-sqlite3/internal/timefmt
cpu: Apple M4 Pro
BenchmarkParse/Stdlib-14 11050214 103.5 ns/op 0 B/op 0 allocs/op
BenchmarkParse/Timefmt-14 34134667 34.45 ns/op 0 B/op 0 allocs/op
BenchmarkParse/Timefmt_T-14 33790362 33.97 ns/op 0 B/op 0 allocs/op
PASS
ok github.com/charlievieth/go-sqlite3/internal/timefmt 3.814s
```
charlievieth
force-pushed
the
cev/parse-time
branch
from
aa086ca to
1c28d1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a dedicated function for parsing the two most common timestamps used by sqlite3.
timefmt benchmarks: