intern error strings #20
Merged
+46
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlievieth
force-pushed
the
cev/error-cache
branch
2 times, most recently
from
e5ebd83 to
834eb60
Compare
This changes the error message cache to intern the error strings/messages. The reasoning for this change is that sqlite3 has a finite number of constant error strings, but potential misuse of the cache could lead to it growing unbounded with a large number of essentially duplicate error messages.
charlievieth
force-pushed
the
cev/error-cache
branch
from
834eb60 to
75dda64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the error message cache to intern the error strings/messages. The reasoning for this change is that sqlite3 has a finite number of constant error strings, but potential misuse of the cache could lead to it growing unbounded with a large number of essentially duplicate error messages.