only reset sqlite3 statement when necessary #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the bind logic to only reset the sqlite3 statement
when necessary, which saves us a call to sqlite3_reset the first time
the query is used.
goos: darwin
goarch: arm64
pkg: github.com/charlievieth/go-sqlite3
cpu: Apple M4 Pro
│ y1.txt │ y2.txt │
│ sec/op │ sec/op vs base │
Suite/BenchmarkQuery-14 1.718µ ± 1% 1.634µ ± 0% -4.89% (p=0.000 n=10)
Suite/BenchmarkQuerySimple-14 1009.0n ± 2% 941.1n ± 0% -6.73% (p=0.000 n=10)
geomean 1.317µ 1.240µ -5.81%
│ y1.txt │ y2.txt │
│ B/op │ B/op vs base │
Suite/BenchmarkQuery-14 640.0 ± 0% 640.0 ± 0% ~ (p=1.000 n=10) ¹
Suite/BenchmarkQuerySimple-14 440.0 ± 0% 440.0 ± 0% ~ (p=1.000 n=10) ¹
geomean 530.7 530.7 +0.00%
¹ all samples are equal
│ y1.txt │ y2.txt │
│ allocs/op │ allocs/op vs base │
Suite/BenchmarkQuery-14 22.00 ± 0% 22.00 ± 0% ~ (p=1.000 n=10) ¹
Suite/BenchmarkQuerySimple-14 13.00 ± 0% 13.00 ± 0% ~ (p=1.000 n=10) ¹
geomean 16.91 16.91 +0.00%
¹ all samples are equal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the bind logic to only reset the sqlite3 statement when necessary, which saves us a call to sqlite3_reset the first time the query is used.