all: rename package to github.com/charlievieth/go-sqlite3 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This project is a hard'ish fork of github.com/mattn/go-sqlite3 that will not always be compatible with the original. Therefore I'm renaming it to avoid confusion. Regarding incompatibilities, the first is that mattn/go-sqlite3 allows for the SQL passed to Query to contain multiple statements, but will only execute the last one - this package will return an error if Query is passed multiple SQL statements. The second incompatibility is that this library will eventually remove the rarely used RegisterAggregator since it uses reflect.MethodByName which disables dead code removal. The goal is to keep the number of incompatibilities to minimum, unless justified by correctness or performance reasons. The overall goal of this package is to be more correct and performant than mattn/go-sqlite3 while not being constrained by backwards compatibility (apart from removing RegisterAggregator this package should only introduce breaking changes to code that is already incorrect).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project is a hard'ish fork of github.com/mattn/go-sqlite3 that will not always be compatible with the original. Therefore I'm renaming it to avoid confusion.
Regarding incompatibilities, the first is that mattn/go-sqlite3 allows for the SQL passed to Query to contain multiple statements, but will only execute the last one - this package will return an error if Query is passed multiple SQL statements. The second incompatibility is that this library will eventually remove the rarely used RegisterAggregator since it uses reflect.MethodByName which disables dead code removal. The goal is to keep the number of incompatibilities to minimum, unless justified by correctness or performance reasons.
The overall goal of this package is to be more correct and performant than mattn/go-sqlite3 while not being constrained by backwards compatibility (apart from removing RegisterAggregator this package should only introduce breaking changes to code that is already incorrect).