Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Polymorphic serialization #4

Closed
frzme opened this issue Jul 15, 2019 · 3 comments
Closed

Support Polymorphic serialization #4

frzme opened this issue Jul 15, 2019 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@frzme
Copy link

frzme commented Jul 15, 2019

It would be nice if Polymorphic (de)serialization was supported in the same way it is for JSON.

(see https://medium.com/@andreclassen1337/goodbye-runtimetypeadapterfactory-polymorphic-serialization-using-kotlinx-serialization-46a8cec36fdc )

@charleskorn charleskorn added enhancement New feature or request help wanted Extra attention is needed labels Jul 16, 2019
@charleskorn
Copy link
Owner

Hi @frzme, thanks for the suggestion!

I don't have capacity to add this in the short term, so if you're keen, I'm happy to provide some pointers and review a PR as you go. I'm imagining this would use YAML's local tags syntax (!square / !circle) to indicate the type - https://camel.readthedocs.io/en/latest/yamlref.html#tags has a good explanation of this. Was that what you had in mind, or were you thinking of something else?

@frzme
Copy link
Author

frzme commented Aug 2, 2019

Hi @charleskorn I was not aware of this feature and thus was thinking of basically the same as in json - but if it yaml has native support for it it sounds great to use it.

Unfortunatly I most likely also won't have capacity to work on it anytime soon.

EdwarDDay pushed a commit to EdwarDDay/kaml that referenced this issue Sep 9, 2019
- implement charleskorn#4
- support yaml tags for polymorphic de-/serialization
EdwarDDay pushed a commit to EdwarDDay/kaml that referenced this issue Sep 9, 2019
- implement charleskorn#4
- support yaml tags for polymorphic de-/serialization
EdwarDDay pushed a commit to EdwarDDay/kaml that referenced this issue Sep 9, 2019
- implement charleskorn#4
- support yaml tags for polymorphic de-/serialization
@charleskorn
Copy link
Owner

This has been resolved with #7 and will be part of the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants