Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more concise syntax in README #20

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Conversation

ali-ramadhan
Copy link
Collaborator

Not sure if this is a positive change but I thought it looked more intuitive.

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #20 (1409dc8) into main (22dae1d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #20   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           62        62           
=========================================
  Hits            62        62           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22dae1d...1409dc8. Read the comment docs.

@charleskawczynski
Copy link
Owner

Yeah, I think that's a good point, actually, considering it's being described as Dict/NamedTuple-like (and those both support obj[key] syntax). Should we update the index.md too?

@ali-ramadhan
Copy link
Collaborator Author

Done! I forgot about the docs lol.

@charleskawczynski
Copy link
Owner

Np, I have mixed feelings about having it in duplicate places. Thanks!

@charleskawczynski
Copy link
Owner

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 17, 2021

@bors bors bot merged commit ca95935 into charleskawczynski:main Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants