Free ICD "library_path" when it contains an empty string

If "library_path" contained nothing, loader_parse_json_string returns the string "", which still needs to be freed.
charles-lunarg · Nov 25, 2024 · 5c0073c · 5c0073c
1 parent 39eb3cf
commit 5c0073c
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/loader/loader.c b/loader/loader.c
@@ -3612,12 +3612,11 @@ VkResult loader_parse_icd_manifest(const struct loader_instance *inst, char *fil
                    "loader_parse_icd_manifest: Failed retrieving ICD JSON %s \'library_path\' field. Skipping ICD JSON.", file_str);
         res = VK_ERROR_OUT_OF_HOST_MEMORY;
         goto out;
-    }
-
-    if (!library_path || strlen(library_path) == 0) {
+    } else if (!library_path || strlen(library_path) == 0) {
         loader_log(inst, VULKAN_LOADER_WARN_BIT | VULKAN_LOADER_DRIVER_BIT, 0,
                    "loader_parse_icd_manifest: ICD JSON %s \'library_path\' field is empty. Skipping ICD JSON.", file_str);
         res = VK_ERROR_INCOMPATIBLE_DRIVER;
+        loader_instance_heap_free(inst, library_path);
         goto out;
     }