-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added DepthAI package and required fixes #1059
Conversation
Thanks, and I'm sorry for not responding to your previous PR – it touched a number of complex areas, so it wasn't easy for me to find time to review. This one looks a lot easier to handle. One of those areas which has become a bit simpler in the last few days is actually installing and running CMake. Please merge from the master branch to pick up these:
Also, to add a new package, we need a test script to verify that it works. Please do the following:
|
version: "2.24.0.0" # If a release is picked | ||
# version: "2.24.0.0.dev0+7b57b28305368582d004d5c6ec2cffb66562f2e0" | ||
|
||
source: | ||
git_url: https://github.com/luxonis/depthai-python.git | ||
git_rev: 7b57b28305368582d004d5c6ec2cffb66562f2e0 | ||
# path: [path/to/depthai-python] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what "If a release is picked" means.
Also, if the commented-out version
and path
lines serve some purpose, please add more comments to explain what that is, or otherwise remove them.
What does "NDA" mean? |
fc78637
to
db1f9bf
Compare
Thanks for the comments! Addressed & force pushed!
Sorry, meant NDK here. Added test case, tested against
|
It looks like since you explicitly added libpython to the link in the CMakeLists file, the changes to the toolchain file were no longer necessary, so I've removed them. The cmake-example recipe had to be fixed in the same way – removing the I was unable to add these changes to this PR because you apparently disabled the "Allow edits from maintainers" option when you created it. Please leave this enabled in future PRs. This package is now in the public repository for Python 3.8 - 3.12. Thanks for the contribution! |
This contains a couple of parts to get everything in place:
This is an iteration/simplification of: #1010, to not require bump of API. To circumvent that, package had to be patch in the background to accomodate for older NDA and explicit link to -lpython3.x had to be added as a patch.
Otherwise a more straightforward PR and still functions as expected