Skip to content

Commit

Permalink
Make pre-release device list more flexible
Browse files Browse the repository at this point in the history
  • Loading branch information
mhsmith committed Oct 13, 2024
1 parent 16c02e7 commit 4d83f60
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 21 deletions.
24 changes: 11 additions & 13 deletions release/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,13 @@ representative device under the following conditions:

Download the `demo` artifact from GitHub Actions, and unpack the APK from it.

Install the APK and run the Java and Python unit tests on the following devices, with at
least one device being a clean install, and at least one being an upgrade from the
previous public release with the tests already run.
Install the APK and run the Java and Python unit tests on all ABIs, with at least one
device being each of the following:

* x86 emulator with minSdkVersion
* x86_64 emulator with minSdkVersion
* x86_64 emulator with targetSdkVersion
* Any armeabi-v7a device
* Any arm64-v8a device
* minSdk
* targetSdk
* A clean install
* An upgrade from the previous public release, with the tests already run

Test all the UI elements of the app on both minSdkVersion and targetSdkVersion.

Expand Down Expand Up @@ -76,12 +74,12 @@ test on a corresponding device:
* armeabi-v7a (use a 32-bit device)
* arm64-v8a

Set `abiFilters` to `"x86", "x86_64"` (this tests the multi-ABI case), and test on the
following devices, with at least one being a clean install:
Set `abiFilters` to `"x86", "x86_64"` (this tests the multi-ABI case), and test on those
ABIs, with at least one device being each of the following:

* x86 emulator with minSdkVersion
* x86_64 emulator with minSdkVersion (TensorFlow is expected to fail because of #669)
* x86_64 emulator with targetSdkVersion
* minSdk
* targetSdk
* A clean install


## Public release
Expand Down
14 changes: 6 additions & 8 deletions server/pypi/README-internal.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,12 @@ which may be less stable. Include these packages in all the remaining tests.
Once everything's working on this ABI, save any edits in the package's `patches`
directory. Then run build-wheel for all other ABIs.

Restore `abiFilters` to include all ABIs. Then test the app on the following devices, with
at least one device being a clean install:

* x86 emulator with minSdkVersion
* x86_64 emulator with minSdkVersion
* x86_64 emulator with targetSdkVersion
* Any armeabi-v7a device
* Any arm64-v8a device
Restore `abiFilters` to include all ABIs, and test them all, with at least one device
being each of the following:

* minSdk
* targetSdk
* A clean install

Repeat the build and test on all other Python versions.

Expand Down

0 comments on commit 4d83f60

Please sign in to comment.