Remove cmake note in quickstart instructions #26490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jade Abraham <[email protected]>
mppf
reviewed
Jan 15, 2025
doc/rst/usingchapel/QUICKSTART.rst
Outdated
| @@ -104,7 +104,7 @@ rebuild Chapel from source in a different configuration: | |||
|
|
|||
| - Or, use ``export CHPL_LLVM=bundled`` to have Chapel build and use the | |||
| bundled version of LLVM. Note that building the bundled version of | |||
| LLVM can take a long time and requires CMake version 3.13.4 or | |||
| LLVM can take a long time and requires CMake version 3.20 or | |||
There was a problem hiding this comment.
IMO we should remove the detail about cmake from this document. It's already covered in the prerequisites, and cmake is required now to build the compiler, not just LLVM, so the note here doesn't seem useful.
Signed-off-by: Jade Abraham <[email protected]>
jabraham17
changed the title
mppf
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the note about cmake being required int the quickstart instructions, since its already a general prereq.
[Reviewed by @mppf]