Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Cray/chapel-private/issues/6923.
Depends on #26454, #26455 and #26456 because this causes more Domain methods to be resolved.
The issue was in resolving code like this:
Previously, dyno incorrectly set
isMethod
to be false, which made thethis
formal for methods to be incorrectly set. This PR adjusts this behavior to correctly track method calls when resolving iterator overloads.Reviewed by @benharsh -- thanks!
Testing