New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make setting CHPL_DEVELOPER to a falsy value be respected #26425

Open

jabraham17 wants to merge 1 commit into chapel-lang:main from jabraham17:fix-chpl-devel

Member

jabraham17 commented Dec 17, 2024

Makes sure setting CHPL_DEVELOPER to a falsy value is respected, by using the isTrue function in our Makefiles rather than ifdef.

Testing

make clobber && make all && make check on M1
- with CHPL_DEVELOPER unset
- with CHPL_DEVELOPER=0 set
- with CHPL_DEVELOPER=false set
- with CHPL_DEVELOPER=1 set
- with CHPL_DEVELOPER=true set
make clobber && make all && make check on linux64
- with CHPL_DEVELOPER unset
- with CHPL_DEVELOPER=n set
- with CHPL_DEVELOPER=y set


          use isTrue instead of ifdef

04de273

Signed-off-by: Jade Abraham <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet