Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix internal error when erroneously writing super.init twice #26421

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix internal error when erroneously writing super.init twice #26421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a41fefc
improve error message for duplicate super.init
jabraham17 Dec 17, 2024
d496cd5
add test case
jabraham17 Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion compiler/passes/initializerRules.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,10 @@ static InitNormalize preNormalize(AggregateType* at,
} else if (isSuperInit(callExpr) == true) {
Expr* next = callExpr->next;

INT_ASSERT(state.isPhase0() == true);
if (state.isPhase0() != true) {
USR_FATAL(callExpr,
"duplicate use of 'super.init()' in initializer, this should only be called once");
}
state.completePhase0(callExpr);

if (at->isRecord() == true) {
Expand Down
11 changes: 11 additions & 0 deletions test/classes/initializers/inheritance/duplicate-super-init.chpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
class P { }
class C: P {
proc init() {
super.init();
super.init();
}
}

proc main() {
var c = new C();
}
2 changes: 2 additions & 0 deletions test/classes/initializers/inheritance/duplicate-super-init.good
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
duplicate-super-init.chpl:3: In initializer:
duplicate-super-init.chpl:5: error: duplicate use of 'super.init()' in initializer, this should only be called once
Loading