Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve basic associative domains with module code in Dyno #26077

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

riftEmber
Copy link
Member

@riftEmber riftEmber commented Oct 11, 2024

Get associative domains resolving using their module code in Dyno, and re-enable testing.

This PR itself contains little work and mostly just drove Dyno work needed to support the module code.

Completes part of https://github.com/Cray/chapel-private/issues/6729.

Also includes:

  • allowing helpResolveFunction to run on generic type constructors, per bug fix suggestion from Ben
  • adjusting the handling of param == ? comparisons which was introduced in Dyno: Improve initialization of fields from non-matching types #26219, so that it gets specially handled rather than trying to resolve a defined == operator
  • some primitive implementations required to resolve module code

[reviewer info placeholder]

Testing:

  • dyno tests
  • paratest

@riftEmber riftEmber marked this pull request as draft October 11, 2024 20:32
@riftEmber riftEmber force-pushed the dyno-associative-domains branch 2 times, most recently from a365a3f to 8070e30 Compare October 14, 2024 15:37
@riftEmber riftEmber force-pushed the dyno-associative-domains branch 7 times, most recently from cadb922 to 87170da Compare October 31, 2024 19:56
@riftEmber riftEmber force-pushed the dyno-associative-domains branch 12 times, most recently from 62eab18 to 262abef Compare November 22, 2024 19:53
@riftEmber riftEmber changed the title Resolve basic associative domains with module code in Dyno Test basic associative domains with module code in Dyno Nov 22, 2024
@riftEmber riftEmber changed the title Test basic associative domains with module code in Dyno Resolve basic associative domains with module code in Dyno Nov 22, 2024
@riftEmber riftEmber force-pushed the dyno-associative-domains branch 2 times, most recently from 9b06d78 to 10b93b0 Compare November 26, 2024 19:57
@riftEmber riftEmber force-pushed the dyno-associative-domains branch 2 times, most recently from 1a03aef to 9d69475 Compare December 2, 2024 19:17
@riftEmber riftEmber force-pushed the dyno-associative-domains branch from 9d69475 to 822d66a Compare December 20, 2024 19:13
@riftEmber riftEmber force-pushed the dyno-associative-domains branch 2 times, most recently from ed1773b to d347fa4 Compare December 20, 2024 19:27
@riftEmber riftEmber force-pushed the dyno-associative-domains branch from d347fa4 to ebad6b3 Compare December 20, 2024 19:28
@riftEmber riftEmber force-pushed the dyno-associative-domains branch from 3daa03d to c00eab0 Compare December 20, 2024 20:35
@riftEmber riftEmber force-pushed the dyno-associative-domains branch from 2b4f69f to 369df9e Compare December 20, 2024 21:14
@riftEmber riftEmber force-pushed the dyno-associative-domains branch 3 times, most recently from 2f5c64b to 4e8086f Compare December 20, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant