Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning to chpl_compare #25877

Merged

Conversation

jabraham17
Copy link
Member

@jabraham17 jabraham17 commented Sep 4, 2024

Adds a deprecation warning to chpl_compare for deprecated usages of comparators. While this is technically an internal function and as such shouldn't need deprecations, it is used by other Chapel standard modules and by some users, so this PR gives a warning instead of code potentially breaking down the road.

  • tested with a full paratest with/without comm

[Reviewed by @lydia-duncan]

Copy link
Member

@lydia-duncan lydia-duncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me, thanks!

@jabraham17 jabraham17 merged commit 24ea5eb into chapel-lang:main Sep 5, 2024
7 checks passed
@jabraham17 jabraham17 deleted the add-deprecation-to-chpl-compare branch September 5, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants