Co-locale support for AMD GPUs #25846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for partitioning AMD GPUs among co-locales. Signed-off-by: John H. Hartman <[email protected]>
jabraham17
approved these changes
Aug 29, 2024
Signed-off-by: John H. Hartman <[email protected]>
jhh67
added a commit
that referenced
this pull request
Oct 9, 2024
The PRs to add GPU support to co-locales (PRs #25734 and #25846) broke oversubscription such that no locales had any GPUs. This PR fixes that problem, and cleans up resource allocation with co-locales in general. Oversubscription is handled more cleanly, as is the "remainder" node that occurs when the number of locales is not evenly divisible by the number of nodes. [Reviewed by @jabraham17, thank you.]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for partitioning GPUs among co-locales.
Resolves https://github.com/Cray/chapel-private/issues/6640.