Fix an issue with library compilation on Macs #25844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…periment I believe we added this extra library specification for a reason (linking is annoyingly fragile), so see if that reason was because of Macs and as a result has now been fixed. Seems to avoid the error message on my Mac, but need to check the behavior on linux ---- Signed-off-by: Lydia Duncan <[email protected]>
Since the previous commit seemed okay on both Mac and Linux, go ahead and do the same thing for these tests. Testing on my Mac worked fine, checking Linux now ---- Signed-off-by: Lydia Duncan <[email protected]>
…ary warning Since Macs seem to object to providing duplicate libraries now, avoid adding it at the end of the generated makefile compilation line. ---- Signed-off-by: Lydia Duncan <[email protected]>
jabraham17
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Library compilation on Macs has recently started generating the error:
I believe we added this extra library specification for a reason (linking is annoyingly fragile), and it seems likely that reason is no longer necessary, so it should be safe to remove the extra library specification in general. Experimentation with removing the extra library linking on linux makes this seem likely.
For many tests, this was part of the specified ".lastcompopts" file and so could be removed from the tests. For the tests of generating Makefiles, we needed to modify the compiler to not add this extra use of the library.
Tested: