Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make atomic peek/poke unstable and opt-in #13888

Merged
merged 6 commits into from
Aug 27, 2019
Merged

Make atomic peek/poke unstable and opt-in #13888

merged 6 commits into from
Aug 27, 2019

Conversation

ronawho
Copy link
Contributor

@ronawho ronawho commented Aug 26, 2019

We're not ready to stabilize peek()/poke() atomic operations, so
move them into an unstable opt-in PeekPoke module. The old
available-by-default versions are deprecated and the new versions are
available with use PeekPoke.

This also corrects the documentation to note that peek()/poke() are
not atomic.

Closes #13827
Closes https://github.com/Cray/chapel-private/issues/392

ronawho added 5 commits August 25, 2019 11:09
@ronawho
Add peek/poke with correct documentation to PeekPoke.chpl
851587f
@ronawho
Deprecate default usage of atomic peek/poke (and correct documentation)
df4a2a8
@ronawho
Add tests for peek/poke
f8f1a1b 
Add correctness tests for opt-in ones, and deprecation tests for the
available-by-default versions.
@ronawho
Update tests for peek/poke deprecation
392b60e 
Use PeekPoke for places that warrant it for performance, and switch some
debug printing to use read/write
@ronawho
Remove atomic peek/poke from the spec
3035e24
@ronawho ronawho requested a review from mppf August 26, 2019 20:21
@ronawho
Copy link
Contributor Author

ronawho commented Aug 26, 2019

I'm planning to wait and see if there's more feedback on #13827, but I think this is ready for an initial review.

Rendered docs are available at http://web/~eronagha/peek-poke/

@ronawho ronawho mentioned this pull request Aug 26, 2019
Closed
mppf
mppf approved these changes Aug 26, 2019
View reviewed changes
@ronawho ronawho merged commit 3699b98 into chapel-lang:master Aug 27, 2019
@ronawho ronawho deleted the opt-in-peek-poke-2 branch August 27, 2019 15:02
@ronawho ronawho mentioned this pull request Aug 27, 2019
Closed
4 tasks
@ronawho ronawho mentioned this pull request Feb 5, 2020
Merged
ronawho added a commit that referenced this pull request Feb 5, 2020
@ronawho
Merge pull request #14855 from ronawho/remove-peek-poke
5d94664 
Remove available-by-default atomic peek/poke

[reviewed by @gbtitus and @mppf]

They were deprecated in #13888.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mppf mppf mppf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make atomic peek()/poke() opt-in and mark them as unstable
2 participants
@ronawho @mppf