Skip to content

Commit

Permalink
Remove legacy GASNet-1 backend (#25875)
Browse files Browse the repository at this point in the history
The legacy GASNet-1 backend has been superseded by the new GASNet-EX backend,
which has been Chapel's default GASNet backend since 658ac15 (Chapel 2.1).

Both backends run over the same GASNet-EX implementation, so this is mostly
just about removing pointlessly duplicated Chapel runtime code, to improve
future maintainability.

Deliberately undocumented setting `CHPL_GASNET_VERSION` is also removed.

Partially reverts 2f4776e

Manually tested on Perlmutter (ofi conduit) and JLSE Cascade (ibv and udp
conduits).

[Reviewed by @jhh67 and @PHHargrove.]
  • Loading branch information
jhh67 authored Oct 15, 2024
2 parents e7ba7c9 + 0424ec2 commit 4f9f8a1
Show file tree
Hide file tree
Showing 14 changed files with 4 additions and 1,809 deletions.
10 changes: 3 additions & 7 deletions runtime/src/comm/gasnet/Makefile.share
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,16 @@
# See the License for the specific language governing permissions and
# limitations under the License.

ifeq ($(CHPL_MAKE_GASNET_VERSION),ex)
COMM_SUFFIX=-ex
endif

COMM_LAUNCHER_SRCS = \
comm-gasnet-launch.c \
comm-gasnet-locales.c \

COMM_SRCS = \
comm-gasnet$(COMM_SUFFIX).c \
comm-gasnet-ex.c \
comm-gasnet-locales.c \

SRCS = \
comm-gasnet$(COMM_SUFFIX).c \
comm-gasnet-ex.c \
comm-gasnet-launch.c \
comm-gasnet-locales.c \

Expand All @@ -49,6 +45,6 @@ endif
endif
endif

$(RUNTIME_OBJ_DIR)/comm-gasnet$(COMM_SUFFIX).o: comm-gasnet$(COMM_SUFFIX).c $(RUNTIME_OBJ_DIR_STAMP)
$(RUNTIME_OBJ_DIR)/comm-gasnet-ex.o: comm-gasnet-ex.c $(RUNTIME_OBJ_DIR_STAMP)
$(CC) -c $(RUNTIME_CFLAGS) $(CHPL_GASNET_CFLAGS) $(RUNTIME_INCLS) -o $@ $<

Loading

0 comments on commit 4f9f8a1

Please sign in to comment.