-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed typos, add more explanations in Issue Resolution Duration for Filters #412
Conversation
I am not sure about changing proxy to dimension. They are not synonyms. Changing this term changes the narrative and meaning of the text (possibly in a good way). Was there a discussion about this somewhere? |
No, this is the place we start the discussion first. :)
"proxy" from my understanding is more like represented as “act on behalf of”, like Java Dynamic Proxy Classes or Proxy server. I am not a native English speaker. I hope that I understand correctly on the these metrics, which are quite important and nice! 👍 |
No worries @eyehwan. It is a good discussion and edits are most certainly welcome. Both terms work here but they mean different things. Dimension may be the better word but I would like to get some other opinions on it because it does change the meaning of the text. I am not sure if it changes it in a substantial way, but if it does, we would need to send this metric back to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Evolution working group thinks this line change to code-changes-lines, code-changes, change-requests-accepted, change-requests, and change-requests-declined should be reverted:
Although code changes can be a proxy to the coding activity of a project,
Although code changes can be a dimension to the coding activity of a project,
During the July 7, 2021 Evolution working group meeting, we discussed these points at length. "Proxy" has a very specific meaning that clearly represents how people use many Evolution metrics as a "proxy for activity". This word will remain, and we welcome your other changes!! THANK YOU!!! |
@sgoggins Thanks for the declarations! Then I will push another patch for the rest of fixes. |
…ilters Signed-off-by: Yehui Wang <[email protected]>
I have updated another patch, to revert dimension back to proxy. |
fixed typos, change key word
proxy
todimension
, add more explanations inIssue Resolution Duration
for Filters