Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typos, add more explanations in Issue Resolution Duration for Filters #412

Merged
merged 1 commit into from
Sep 7, 2021
Merged

fixed typos, add more explanations in Issue Resolution Duration for Filters #412

merged 1 commit into from
Sep 7, 2021

Conversation

eyehwan
Copy link
Member

@eyehwan eyehwan commented Jun 19, 2021

fixed typos, change key word proxy to dimension, add more explanations in Issue Resolution Duration for Filters

@klumb
Copy link
Member

klumb commented Jun 23, 2021

I am not sure about changing proxy to dimension. They are not synonyms.

Changing this term changes the narrative and meaning of the text (possibly in a good way).

Was there a discussion about this somewhere?

@eyehwan
Copy link
Member Author

eyehwan commented Jun 24, 2021

Was there a discussion about this somewhere?

No, this is the place we start the discussion first. :)

I am not sure about changing proxy to dimension. They are not synonyms.
Changing this term changes the narrative and meaning of the text (possibly in a good way).

"proxy" from my understanding is more like represented as “act on behalf of”, like Java Dynamic Proxy Classes or Proxy server.
But here Although code changes can be a **proxy** to the coding activity of a project, makes me confused somewhat.
If I changed it to dimension, it looks more clear that code change is a dimension of measuring the the coding activity of a project

I am not a native English speaker. I hope that I understand correctly on the these metrics, which are quite important and nice! 👍

@klumb
Copy link
Member

klumb commented Jun 24, 2021

No worries @eyehwan. It is a good discussion and edits are most certainly welcome.

Both terms work here but they mean different things.

Dimension may be the better word but I would like to get some other opinions on it because it does change the meaning of the text. I am not sure if it changes it in a substantial way, but if it does, we would need to send this metric back to review.

@sgoggins @foundjem - what do you think?

Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Evolution working group thinks this line change to code-changes-lines, code-changes, change-requests-accepted, change-requests, and change-requests-declined should be reverted:

  Although code changes can be a proxy to the coding activity of a project,
  Although code changes can be a dimension to the coding activity of a project,

@sgoggins
Copy link
Member

sgoggins commented Jul 7, 2021

The Evolution working group thinks this line change to code-changes-lines, code-changes, change-requests-accepted, change-requests, and change-requests-declined should be reverted:

  Although code changes can be a proxy to the coding activity of a project,
  Although code changes can be a dimension to the coding activity of a project,

During the July 7, 2021 Evolution working group meeting, we discussed these points at length. "Proxy" has a very specific meaning that clearly represents how people use many Evolution metrics as a "proxy for activity". This word will remain, and we welcome your other changes!! THANK YOU!!!

@eyehwan
Copy link
Member Author

eyehwan commented Jul 14, 2021

@sgoggins Thanks for the declarations! Then I will push another patch for the rest of fixes.

@eyehwan eyehwan changed the title fixed typos, change key word proxy to dimension, add more explanations in Issue Resolution Duration for Filters fixed typos, add more explanations in Issue Resolution Duration for Filters Jul 25, 2021
@eyehwan
Copy link
Member Author

eyehwan commented Jul 25, 2021

I have updated another patch, to revert dimension back to proxy.

@sgoggins sgoggins merged commit 27300e5 into chaoss:master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants