Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Improve job criteria form UX #841

Merged
merged 1 commit into from
Dec 12, 2023
+108 −50
Merged

[ui] Improve job criteria form UX #841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions releases/unreleased/improve-readability-of-form-options.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
title: Improved readability of job settings
category: added
author: Eva Millán <[email protected]>
issue: null
notes: >
The options for the "unify" and "recommend matches"
jobs are now displayed in a clearer way.
146 changes: 96 additions & 50 deletions ui/src/components/JobModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,56 +43,102 @@
/>
</v-col>
</v-row>
<v-row v-if="selected === 'unify'">
<v-col>
<v-select
v-model="forms.unify.criteria"
:items="['name', 'email', 'username']"
:menu-props="{ bottom: true, offsetY: true }"
label="Criteria"
dense
hide-details
multiple
outlined
/>
<v-checkbox
v-model="forms.unify.strict"
label="Exclude individuals with invalid email adresses and names"
id="unify_strict"
hide-details
/>
<v-checkbox
v-model="forms.unify.exclude"
label="Exclude individuals in RecommenderExclusionTerm list"
id="unify_exclude"
/>
</v-col>
</v-row>
<v-row v-if="selected === 'recommendMatches'">
<v-col>
<v-select
v-model="forms.recommendMatches.criteria"
:items="['name', 'email', 'username']"
:menu-props="{ bottom: true, offsetY: true }"
label="Criteria"
dense
hide-details
multiple
outlined
/>
<v-checkbox
v-model="forms.recommendMatches.strict"
label="Exclude individuals with invalid email adresses and names"
id="recommend_strict"
hide-details
/>
<v-checkbox
v-model="forms.recommendMatches.exclude"
label="Exclude individuals in RecommenderExclusionTerm list"
id="recommend_exclude"
/>
</v-col>
</v-row>
<v-form v-if="selected === 'unify'">
<v-row class="ma-0 mt-2">
<v-col class="pa-0 mb-3">
<v-checkbox
v-model="forms.unify.exclude"
label="Exclude individuals in RecommenderExclusionTerm list"
dense
hide-details
/>
<v-checkbox
v-model="forms.unify.strict"
label="Exclude individuals with invalid email adresses and names"
dense
hide-details
/>
</v-col>
</v-row>
<v-row class="ma-0">
<v-col class="pa-0">
<fieldset>
<legend class="subheader text--secondary">
Unify profiles based on their:
</legend>
<v-checkbox
v-model="forms.unify.criteria"
label="Name"
value="name"
dense
hide-details
/>
<v-checkbox
v-model="forms.unify.criteria"
label="Email"
value="email"
dense
hide-details
/>
<v-checkbox
v-model="forms.unify.criteria"
label="Username"
value="username"
dense
hide-details
/>
</fieldset>
</v-col>
</v-row>
</v-form>
<v-form v-if="selected === 'recommendMatches'">
<v-row class="ma-0 mt-2">
<v-col class="pa-0 mb-3">
<v-checkbox
v-model="forms.recommendMatches.exclude"
label="Exclude individuals in RecommenderExclusionTerm list"
dense
hide-details
/>
<v-checkbox
v-model="forms.recommendMatches.strict"
label="Exclude individuals with invalid email adresses and names"
dense
hide-details
/>
</v-col>
</v-row>
<v-row class="ma-0">
<v-col class="pa-0">
<fieldset>
<legend class="subheader text--secondary">
Recommend matches based on:
</legend>
<v-checkbox
v-model="forms.recommendMatches.criteria"
label="Name"
value="name"
dense
hide-details
/>
<v-checkbox
v-model="forms.recommendMatches.criteria"
label="Email"
value="email"
dense
hide-details
/>
<v-checkbox
v-model="forms.recommendMatches.criteria"
label="Username"
value="username"
dense
hide-details
/>
</fieldset>
</v-col>
</v-row>
</v-form>
</v-card-text>
<v-card-actions>
<v-spacer></v-spacer>
Expand Down
4 changes: 4 additions & 0 deletions ui/src/styles/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,3 +194,7 @@ button.v-pagination__item {
.v-snack__content::first-letter {
text-transform: capitalize;
}

fieldset {
border: 0;
}