Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Improve organization selector #825

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

evamillan
Copy link
Contributor

This PR makes the organization selector on the enroll modal larger and adds the option to create an organization from the selector itself.

Fixes #820.

Adds the option to create an organization in the
OrganizationSelector component if the searched name
does not match any existing organization.

Signed-off-by: Eva Millán <[email protected]>
@sduenas sduenas force-pushed the improve-org-selector branch from 6fcd168 to a63b812 Compare October 19, 2023 11:56
@@ -44,6 +46,7 @@
</v-dialog>
</template>


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax checker is complaining about this line, please remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please fix the minor issue about the style.

Makes the enrollment modal and the organization selector in
it larger to allow for longer names.

Signed-off-by: Eva Millán <[email protected]>
@evamillan evamillan force-pushed the improve-org-selector branch from a63b812 to 5fbfa95 Compare October 19, 2023 13:40
@sduenas sduenas merged commit 1195aaf into chaoss:master Oct 19, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve organization selector
2 participants