[client] Allow not to verify SSL certificates #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjmerchante
force-pushed
the
verify-ssl
branch
from
db3204c to
aebacfa
Compare
This commit allow to perform SSL requests to a domain without verifying its certificate with the option `ssl_verify`. This commit changes the class for sgqlc endpoint. It now uses RequestsEndpoint because is easier to define a session with the verify option to False. With HTTPEndpoint it should be necessary to overwrite the urlopen function with a custom context with SSL disabled. Signed-off-by: Jose Javier Merchante <[email protected]>
jjmerchante
force-pushed
the
verify-ssl
branch
from
aebacfa to
fd2e443
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to perform SSL requests to a domain without verifying its certificate.
This PR changes the class for sgqlc endpoint. It now uses RequestsEndpoint because is easier to define a session with the verify option to False. With HTTPEndpoint it should be necessary to overwrite the urlopen function with a custom context with SSL disabled.
Update sgqlc package to lastest version.