Fix identity refresh bug for all roles

This commit resolves an issue where role identities
(like `reviewed_by` or `merged_by` among others) were not
refreshed.
The bug occurred because the queries to OpenSearch filtered
items in which `author_uuid` was the individual pk, but not
when the `<role>_uuid` was the individual pk. That causes many
items that contain the `<role>_uuid` but not the `author_uuid`
not to be refreshed.

For example, the `Author` role was not affected because it
matched `author_uuid`, but roles like `reviewed_by` did not
match and were missed.

Signed-off-by: Jose Javier Merchante <[email protected]>

releases/unreleased/identity-refresh-bug-for-some-items.yml

@@ -0,0 +1,9 @@
+---
+title: Identity refresh bug for some items
+category: fixed
+author: Jose Javier Merchante <[email protected]>
+issue: null
+notes: >
+  Fix issue where some fields were not refreshed
+  in the identities database under certain
+  circumstances.

sirmordred/task_enrich.py

@@ -249,12 +249,16 @@ def __autorefresh(self, enrich_backend, studies=False):
         next_autorefresh = self.__update_last_autorefresh()
 
         logger.debug('Getting last modified identities from SH since %s for %s', after, self.backend_section)
+
         author_fields = ["author_uuid"]
+        for role in enrich_backend.roles:
+            author_fields.append(role + '_uuid')
         try:
             meta_fields = enrich_backend.meta_fields
             author_fields += meta_fields
         except AttributeError:
             pass
+
         logger.debug("Refreshing identity ids for %s", self.backend_section)
         total = 0
         time_start = datetime.now()