Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword Bugzilla's and Bugzillarest's descriptions #974

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

stevenkolawole
Copy link
Contributor

@stevenkolawole stevenkolawole commented Mar 31, 2021

Bugzilla and Bugzillarestrefers to the backends/APIs that is used in retrieving the data.
This commit rewords their description to denote the differences between the structure of both data and how they're obtained.

References: #972
Signed-off-by: stevekola [email protected]

@stevenkolawole
Copy link
Contributor Author

@sduenas, I think I messed up the rebase command, so I'm creating a new PR.
Should I close the other?

@sduenas
Copy link
Member

sduenas commented Mar 31, 2021

@sduenas, I think I messed up the rebase command, so I'm creating a new PR.
Should I close the other?

You can keep pushing to this one. Just use the option --force to overwrite the commits that are on it.

@coveralls
Copy link

coveralls commented Mar 31, 2021

Pull Request Test Coverage Report for Build 708717338

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.262%

Totals Coverage Status
Change from base Build 690573792: 0.0%
Covered Lines: 8612
Relevant Lines: 10469

💛 - Coveralls

Copy link
Member

@vchrombie vchrombie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @SteveKola.
Just had a minor comment on the changes.

I see you have already closed the other PR, can you rebase this branch with the master?
You can use the --force during git push after rebasing.

Let us know if you need any help.

@stevenkolawole stevenkolawole force-pushed the master branch 2 times, most recently from cae32cc to 5a87f79 Compare April 1, 2021 12:20
@stevenkolawole
Copy link
Contributor Author

Alright. I have rebased the branch with the master.

'Bugzilla' and 'Bugzillarest' are the enricher backends that store
data that is fetched from the Bugzilla datasource. This commit
rewords their descriptions in the README.md to denote the
differences like how they are fetched.

Resolves chaoss#972
Signed-off-by: stevekola <[email protected]>
@sduenas sduenas merged commit a964d54 into chaoss:master Apr 5, 2021
@sduenas
Copy link
Member

sduenas commented Apr 5, 2021

Merged. Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants