-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qm-elk] Add support for QM data enrichment #902
Conversation
ced3694
to
c9dd068
Compare
This commit adds the gitlabqm enricher. The base file, qmenrich.py is added. The connectors for the enricher are also updated. Signed-off-by: Venu Vardhan Reddy Tekula <[email protected]>
c9dd068
to
a59194f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @valeriocos
I have completed working on the enricher but I had one doubt in the current implementation regarding to files_changed
.
I think it is ready for review, please have a look when you are free. 😄
This commit adds the gitlabqm enricher. The connectors for the enricher are also updated. Signed-off-by: Venu Vardhan Reddy Tekula <[email protected]>
a59194f
to
5e620dc
Compare
Pull Request Test Coverage Report for Build 2314
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vchrombie , the PR looks great, good job! I tested the PR on https://gitlab.com/Bitergia/devops/indexwarrior. I paid special attention to git, and compare the output of the data retrieved with git log --pretty=format:"%h%x09%an%x09%cd%x09%s" --all
with the one available on the enriched indexes.
I left some comments mostly around the timezone. Please check them when you have time.
It would be convenient to add the schema of the quality models data at https://github.com/chaoss/grimoirelab-elk/tree/master/schema and the tests.
Thanks
EDIT: I forgot to add one of the things we discussed in the last GSoC meeting. The QM enrichers should go to a specific module, as similarly done for the SCMS ones. On the other hand, the tests for the QM enrichers don't need to be separated from the rest.
Hi @valeriocos
Sure, I will implement all these things and produce the next PR as an extension of this PR soon. |
This commit is in reference to the issues raised - fix the date normalizing errors and also problems related to the timezone - made the '.git' string optional Signed-off-by: Venu Vardhan Reddy Tekula <[email protected]>
This commit is in reference to the issues raised - fix the date normalizing errors and also problems related to the timezone - made the '.git' string optional - fix the value error Signed-off-by: Venu Vardhan Reddy Tekula <[email protected]>
This commit is in reference to the issues raised - fix the date normalizing errors and also problems related to the timezone - made the '.git' string optional - fix the value error Signed-off-by: Venu Vardhan Reddy Tekula <[email protected]>
This commit is in reference to the issues raised - fix the date normalizing errors and also problems related to the timezone - made the '.git' string optional - fix the value error Signed-off-by: Venu Vardhan Reddy Tekula <[email protected]>
closing this PR, in reference to #926 |
This commit is in reference to the issues raised - fix the date normalizing errors and also problems related to the timezone - made the '.git' string optional - fix the value error Signed-off-by: Venu Vardhan Reddy Tekula <[email protected]>
This commit is in reference to the issues raised - fix the date normalizing errors and also problems related to the timezone - made the '.git' string optional - fix the value error Signed-off-by: Venu Vardhan Reddy Tekula <[email protected]>
This commit is in reference to the issues raised - fix the date normalizing errors and also problems related to the timezone - made the '.git' string optional - fix the value error Signed-off-by: Venu Vardhan Reddy Tekula <[email protected]>
This PR contains gitlabqm and gitqm enrichers.
metrics discussion for gitqm: vchrombie/gsoc#9
output example for gitqm: gist-file-gitqm
micro-mordred configurations
project.json
setup.cfg