Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enriched/git] Add more git commit meta fields #1087

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

zhquan
Copy link
Member

@zhquan zhquan commented Oct 26, 2022

This code extracts more authors meta info:

  • Approved-by
  • Co-authored-by
  • Merged-by

For each one it will creates 10 new fields.

  • suffixes: _bots, _domains, _names, _org_names, _uuids
  • prefix: non_authored_

Example of Merged-by:

  • merged_by_multi_bots
  • merged_by_multi_domains
  • merged_by_multi_names
  • merged_by_multi_org_names
  • merged_by_multi_uuids
  • non_authored_merged_by_multi_bots
  • non_authored_merged_by_multi_domains
  • non_authored_merged_by_multi_names
  • non_authored_merged_by_multi_org_names
  • non_authored_merged_by_multi_uuids

Signed-off-by: Quan Zhou [email protected]

@coveralls
Copy link

coveralls commented Oct 26, 2022

Pull Request Test Coverage Report for Build 3337812346

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 75 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 82.633%

Files with Coverage Reduction New Missed Lines %
/home/runner/work/grimoirelab-elk/grimoirelab-elk/grimoire_elk/enriched/git.py 75 72.52%
Totals Coverage Status
Change from base Build 3328664871: 0.0%
Covered Lines: 9026
Relevant Lines: 10923

💛 - Coveralls

@jjmerchante
Copy link
Contributor

LGTM

Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would you mind to update the changelog with my suggestion and rebase this PR?

Comment on lines 6 to 25
notes: >
Extract more author info on the commits:
- Approved-by: NAME <EMAIL>
- Co-authored-by: NAME <EMAIL>
- Merged-by NAME: <EMAIL>

For each one it will creates 10 more fields.
- suffixes: `_bots`, `_domains`, `_names`, `_org_names`, `_uuids`
- prefix: `non_authored_`

Example of Merged-by:
- merged_by_multi_bots
- merged_by_multi_domains
- merged_by_multi_names
- merged_by_multi_org_names
- merged_by_multi_uuids
- non_authored_merged_by_multi_bots
- non_authored_merged_by_multi_domains
- non_authored_merged_by_multi_names
- non_authored_merged_by_multi_org_names
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
notes: >
Extract more author info on the commits:
- Approved-by: NAME <EMAIL>
- Co-authored-by: NAME <EMAIL>
- Merged-by NAME: <EMAIL>
For each one it will creates 10 more fields.
- suffixes: `_bots`, `_domains`, `_names`, `_org_names`, `_uuids`
- prefix: `non_authored_`
Example of Merged-by:
- merged_by_multi_bots
- merged_by_multi_domains
- merged_by_multi_names
- merged_by_multi_org_names
- merged_by_multi_uuids
- non_authored_merged_by_multi_bots
- non_authored_merged_by_multi_domains
- non_authored_merged_by_multi_names
- non_authored_merged_by_multi_org_names
notes: >
New information about the participants during the development and the
reviewing processes are available in `Git` items. The Git backend extracts
these data from `Approved-by`, `Co-authored-by`, and `Merged-by`
trailers that some commit messages might include. For each one of these
trailers, new fields will be available with the suffixes: `_bots`, `_domains`,
`_names`, `_org_names`, and `_uuids`. Also for each one of these suffixes,
there will be extra fields with the prefix `non_authored_`.
This is an example of the fields available for the the trailer `Merged-by`:
- merged_by_multi_bots
- merged_by_multi_domains
- merged_by_multi_names
- merged_by_multi_org_names
- merged_by_multi_uuids
- non_authored_merged_by_multi_bots
- non_authored_merged_by_multi_domains
- non_authored_merged_by_multi_names
- non_authored_merged_by_multi_org_names

@@ -0,0 +1,25 @@
---
title: Git extracts more authors meta info
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Git extracts more authors meta info
title: Development and reviewing contributors fields for Git items

This code extracts more authors meta info:
- Approved-by
- Co-authored-by
- Merged-by

For each one it will creates 10 new fields.
- suffixes: `_bots`, `_domains`, `_names`, `_org_names`, `_uuids`
- prefix: `non_authored_`

Example of Merged-by:
- merged_by_multi_bots
- merged_by_multi_domains
- merged_by_multi_names
- merged_by_multi_org_names
- merged_by_multi_uuids
- non_authored_merged_by_multi_bots
- non_authored_merged_by_multi_domains
- non_authored_merged_by_multi_names
- non_authored_merged_by_multi_org_names
- non_authored_merged_by_multi_uuids

Signed-off-by: Quan Zhou <[email protected]>
@zhquan zhquan force-pushed the more_git_meta_fields branch from 442169a to 48a31b5 Compare October 27, 2022 13:28
Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sduenas sduenas merged commit ab9edaf into chaoss:master Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants