[enrich/demographics] Fix fetching authors with min and max dates #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2434201959
💛 - Coveralls |
jjmerchante
requested changes
May 31, 2022
zhquan
force-pushed
the
fix_demographics
branch
4 times, most recently
from
2f833e8 to
59f31fc
Compare
This code fixes fetching all authors with min and max dates. Currently, ElasticSearch and OpenSearch use `composite` aggregation to paginate all buckets. The old query only returns 10000 items and also returns the following warning message: ``` Deprecation: This aggregation creates too many buckets (10001) and will throw an error in future versions. You should update the [search.max_buckets] cluster setting or use the [composite] aggregation to paginate all buckets in multiple requests. ``` Tests added acconrdingly. Signed-off-by: Quan Zhou <[email protected]>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code fixes fetching all authors with min and max dates.
Currently, ElasticSearch and OpenSearch use
compositeaggregationto paginate all buckets.
The old query only returns 10000 items and also returns the
following warning message:
Tests added acconrdingly.
Signed-off-by: Quan Zhou [email protected]