Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[github2] Add comments from "Approval" and "Change requests" #1024

Merged
merged 1 commit into from
Jan 21, 2022
Merged

[github2] Add comments from "Approval" and "Change requests" #1024

merged 1 commit into from
Jan 21, 2022

Conversation

zhquan
Copy link
Member

@zhquan zhquan commented Jan 20, 2022

New fields:

  • comment_created_at
  • review_state

Tests updated accordingly.
Schema updated accordingly.

Signed-off-by: Quan Zhou [email protected]

@zhquan
[github2] Add comments from "Approval" and "Change requests"
1acffd8 
New fields:
- comment_created_at
- review_state

Tests updated accordingly.
Schema updated accordingly.

Signed-off-by: Quan Zhou <[email protected]>
@zhquan zhquan force-pushed the github2_add_reviews branch from b1e773e to 1acffd8 Compare January 20, 2022 14:20
@coveralls
Copy link

coveralls commented Jan 20, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1723840856

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 24 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 81.963%
Files with Coverage Reduction New Missed Lines %
/home/runner/work/grimoirelab-elk/grimoirelab-elk/grimoire_elk/enriched/github2.py 24 91.56%
Totals Coverage Status
Change from base Build 1692645653: 0.03%
Covered Lines: 8770
Relevant Lines: 10700
💛 - Coveralls

sduenas
sduenas approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhquan zhquan closed this in b174a12 Jan 21, 2022
@zhquan zhquan merged commit b174a12 into chaoss:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sduenas sduenas sduenas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhquan @coveralls @sduenas