Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translation contribution guide #97

Merged

Conversation

ElisaCapololo
Copy link
Contributor

This PR is a translation work

Changes

Screenshots

guide

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Fixes #

@aosccode
Copy link

Fixes #88

Copy link

@aosccode aosccode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution and your hard work @ElisaCapololo. I just left a couple of comm

@@ -1,2 +1,20 @@
This is the link to the slack bot wiki basic information page to be translated.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this line here :)

[Basic Information](https://github.com/chaoss/chaoss-slack-bot/wiki/Basic-Information)

> ### Informação básica

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be Informações básicas?

> ### Informação básica

> #### Funções do bot

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be Funcionalidades do bot in IMHO :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are fixing more than one issue, you should mention that.

I see this PR fixes #90, #85, #83, and #88

Either you use this PR to fix all the issues, or open a new PR for each issue.
I am not sure fixing all four issues in one PR will be counted as 4 PRs. Please choose wisely :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this PR is solving what #92 is already fixing, and other changes are unrelated to the issue, I think we should close this PR.
CC: @Busayo-ojo


## Abrindo um problema

Se você estiver enfrentando problemas com o CHAOSS Slack Bot ou tiver alguma dúvida que gostaria de ajuda para responder, sinta-se à vontade para abrir um [issue](https://github.com/chaoss/chaoss-slack-bot/issues). Para nos ajudar a evitar duplicatas, pedimos que você pesquise brevemente o seu problema ou dúvida em nossas [issues](https://github.com/chaoss/chaoss-slack-bot/issues) antes de abrir uma nova. Observe que se você abrir um relatório de bug, não poderemos ajudá-lo até que você nos forneça todas as informações relevantes. Respeitosamente, não temos tempo para tentar recriar um erro fornecido com o mínimo ou nenhum contexto, portanto, ao fornecer essas informações, você está nos ajudando a ajudá-lo! Forneça descrições da melhor maneira possível e inclua capturas de tela e erroros de logs, se aplicável.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be nice if we have one line per sentence.
@Busayo-ojo do you have any thoughts?

```
6. Envie uma pull request. Neste ponto, você está esperando por nós. Gostamos de comentar pelo menos as solicitações pull request dentro de três dias úteis (e, normalmente, um dia útil). Assim que um de nossos mantenedores tiver a chance de revisar seu PR, iremos marcá-lo como "revisão necessária" e fornecer feedback específico sobre suas alterações ou prosseguiremos e concluiremos a solicitação pull request.

## Signing-off em Commits

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adicione assinatura nos commits :)

@aosccode
Copy link

I have seen that #85 has being fixed by #92 and it was submitted earlier than this PR :)

@antonio-pedro99
Copy link

Hi @ElisaCapololo, can you remove the translation of the Contributing Guide from this PR? It is being fixed by #85 already
BTW, are you addressing my comments?

Signed-off-by: Elisa Capololo <[email protected]>
@Busayo-ojo
Copy link
Collaborator

Thanks for working on this @ElisaCapololo!

@Busayo-ojo Busayo-ojo merged commit 89dcbed into chaoss:main Oct 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants