Fix RabbitMQ config issue in Docker #2739
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,41 @@ | |||
| from os import environ as env | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0114: Missing module docstring (missing-module-docstring)
| @@ -0,0 +1,41 @@ | |||
| from os import environ as env | |||
| import json, subprocess | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0410: Multiple imports on one line (json, subprocess) (multiple-imports)
|
|
||
| config_file = Path("/etc/rabbitmq/definitions.json") | ||
|
|
||
| with config_file.open() as file: |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
| with config_file.open() as file: | ||
| config = json.load(file) | ||
|
|
||
| hash_processor = subprocess.run(f"rabbitmqctl hash_password {rabbit_pass}".split(), |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W1510: 'subprocess.run' used without explicitly defining the value for 'check'. (subprocess-run-check)
There was a problem hiding this comment.
We should probably set check to True here so it doesn't fail silently.
There was a problem hiding this comment.
| config["permissions"][0]["user"] = rabbit_user | ||
| config["permissions"][0]["vhost"] = rabbit_vhost | ||
|
|
||
| with config_file.open("w") as file: |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
Signed-off-by: Ulincsys <[email protected]>
Ulincsys
force-pushed
the
docker-rabbitmq-fix
branch
from
6280305 to
02d3298
Compare
| with config_file.open() as file: | ||
| config = json.load(file) | ||
|
|
||
| hash_processor = subprocess.run(f"rabbitmqctl hash_password {rabbit_pass}".split(), |
There was a problem hiding this comment.
We should probably set check to True here so it doesn't fail silently.
|
Oh I just saw that it checks the return code never mind. |
Description
definitions.jsonto contain default user, password, and vhost definitionsupdate_config.pyto convert Docker args to RabbitMQ config itemsaugur.confis doing anything anymore, but there's no reason to get rid of it as of right nowupdate_config.pyrabbitmqctldefinitions.json, update with new values and write changesadvanced.configRUN echo ...definitions.jsondocker-compose.ymlenvironmentsection toargssection, update formattingaugur_vhost)rabbitmq/DockerfileSigned commits