docker-compose -> docker compose #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gary White Jr <[email protected]>
GaryPWhite
commented
Feb 19, 2024
| @@ -24,7 +24,6 @@ missingModules="" | |||
| #Check everything that needs to be in the $PATH is in there. | |||
| #Bash doesn't let this work if this is in an if statement for some reason it has to be chained | |||
| type -P "docker" &>/dev/null && echo "docker found..." || missingModules="${missingModules} docker" | |||
| type -P "docker-compose" &>/dev/null && echo "docker-compose found..." || missingModules="${missingModules} docker-compose" | |||
There was a problem hiding this comment.
I can understand why this might be problematic / scary. The reason I filed this PR is because on a modern release of RHEL we must use backports / unstable downloads to get an unsupported version of docker-compose -- happy to discuss alternatives.
sgoggins
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
docker-composeas it was deprecated in June 2023Notes for Reviewers
Signed commits