Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add print traceback method to pr worker #1559

Merged
merged 2 commits into from
Jan 13, 2022
Merged

Add print traceback method to pr worker #1559

merged 2 commits into from
Jan 13, 2022

Conversation

ABrain7710
Copy link
Contributor

@ABrain7710 ABrain7710 commented Jan 12, 2022 •
edited
Loading

  1. Add a method that will print the stack trace when an exception is registered instead of repeating this code block every time
    self.logger.debug(f'exception: {e}.')
    stacker = traceback.format_exc()
    self.logger.debug(f"{stacker}")

@ABrain7710
Add print_traceback method
78b4d38 
Signed-off-by: Andrew Brain <[email protected]>
@ABrain7710 ABrain7710 requested a review from sgoggins as a code owner January 12, 2022 21:53
sgoggins
sgoggins approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm going to run it in the test branch before release.

@sgoggins sgoggins changed the base branch from main to test January 13, 2022 19:11
sgoggins
sgoggins approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Going to run it in test before release.

@sgoggins sgoggins merged commit 966698e into test Jan 13, 2022
@ABrain7710 ABrain7710 deleted the andrew-print-traceback-method branch January 13, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgoggins sgoggins sgoggins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ABrain7710 @sgoggins