Isaac commit resolution #1548
Merged
Isaac commit resolution #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Isaac Milarsky <[email protected]>
…ins has been resolved earlier\' and then becomes unresponsive Signed-off-by: Isaac Milarsky <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
… but I might have to Signed-off-by: Isaac Milarsky <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
sgoggins
approved these changes
Jan 6, 2022
sgoggins
reviewed
Jan 6, 2022
| self.logger.info( | ||
| f"Updated rate limit, you have: {self.oauths[0]['rate_limit']} requests remaining." | ||
| ) | ||
|
|
||
| #Stalls after here for some reason. |
There was a problem hiding this comment.
I have seen stalling on heavily taxed machines. Are you seeing this only in the facade worker resolution or elsewhere?
There was a problem hiding this comment.
I haven't seen it elsewhere yet and it hasn't happened with facade when I have been testing it most recently. I think that comment might be talking about a bug that has since been squashed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The facade worker now uses the commit sha to attempt to resolve commit emails to contributors before anything else. Also other smaller changes to log statements and minor refactors to make more readable.