Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize chaosblade resource state flow in k8s experiments #22

Merged
merged 2 commits into from
Apr 24, 2020
Merged

Optimize chaosblade resource state flow in k8s experiments #22

merged 2 commits into from
Apr 24, 2020

Conversation

xcaspar
Copy link
Member

@xcaspar xcaspar commented Apr 24, 2020 •
edited
Loading

Describe what this PR does / why we need it

Does this pull request fix one issue?

chaosblade-io/chaosblade#336

Describe how you did it

  1. Even if the execution fails, it will not return requeue or error.
  2. Re-creation is allowed only when the state is Initial, and Initialized state is added to avoid the condition that the experiment has been created but the state update fails.
  3. When updating the blade resource spec, the previous spec will be added to metadata.annotations to destroy previous experiments.

The resource status flow is as follows:
ChaosBlade状态流转（详细版） (1)

Describe how to verify it

Special notes for reviews

@xcaspar xcaspar added the type/enhancement New feature or request label Apr 24, 2020
@xcaspar xcaspar added this to the v0.6.0 milestone Apr 24, 2020
@xcaspar xcaspar requested a review from RinaisSuper April 24, 2020 03:06
@RinaisSuper RinaisSuper merged commit f02946e into master Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RinaisSuper RinaisSuper RinaisSuper approved these changes

Assignees
No one assigned
Labels
type/enhancement New feature or request
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@xcaspar @RinaisSuper