Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

fix(edit-kpi): kpi validation triggered on edit kpi #996

Merged
merged 1 commit into from
Jun 16, 2022
Merged

fix(edit-kpi): kpi validation triggered on edit kpi #996

merged 1 commit into from
Jun 16, 2022

Conversation

varunp2k
Copy link
Member

Fixes #995

@gitpod-io
Copy link

gitpod-io bot commented Jun 16, 2022

@netlify
Copy link

netlify bot commented Jun 16, 2022 •
edited
Loading

✅ Deploy Preview for frontend-sb ready!

Name Link
🔨 Latest commit 699d436
🔍 Latest deploy log https://app.netlify.com/sites/frontend-sb/deploys/62aaec33f12acb0008f008d7
😎 Deploy Preview https://deploy-preview-996--frontend-sb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@varunp2k varunp2k requested a review from Samyak2 June 16, 2022 08:39
@varunp2k varunp2k changed the base branch from main to develop June 16, 2022 09:01
@Samyak2 Samyak2 added this to the v0.9.0 milestone Jun 16, 2022
@Samyak2 Samyak2 added 🐛 bug Something isn't working 🛠️ backend labels Jun 16, 2022
@Samyak2 Samyak2 changed the title Fix/edit kpi validation fix(edit-kpi): kpi validation triggered on edit kpi Jun 16, 2022
Samyak2
Samyak2 approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@Samyak2 Samyak2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally.

@Samyak2 Samyak2 merged commit 891e52d into develop Jun 16, 2022
@Samyak2 Samyak2 deleted the fix/edit-kpi-validation branch June 16, 2022 09:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Samyak2 Samyak2 Samyak2 approved these changes

Assignees
No one assigned
Labels
🛠️ backend 🐛 bug Something isn't working
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

[BUG] Edit KPI does not trigger KPI Validation
2 participants
@varunp2k @Samyak2