This repository has been archived by the owner on Sep 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rjdp
commented
Jun 9, 2022
•
edited
Loading
edited
- add "count_column" to KPI model 80fd1d0
- add "Update KPI" query to migration script for upgrade instance 80fd1d0
- read "count_column" from configured value in KPI definition instead of using hardcoded "count" value a318e31
- add KPI validation to make sure selected count_column is of integer type 40856b2
- Fixes for the failing pytests because of this change c61ea1e
…or checking whether datasource is Druid
✅ Deploy Preview for frontend-sb canceled.
|
LGTM, Just one question, the count column should be ideally visible in case of druid (or similar data source in future). How are we planning to do the same? |
@manassolanki currently its being used only incase when Druid is the datasource ( in KPI add form as well it comes up only when Druid is chosen) , but we plan to use same field when we handle preaggregation usecases across more DBs/DWs |
ok, you mean this is hardcode on the frontend side right now. |
@manassolanki it was hardcoded on backend
|
manassolanki
approved these changes
Jun 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.