This repository has been archived by the owner on Sep 12, 2024. It is now read-only.
refactor(kpi-controller): fix type errors and lint issues #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added `Optional[]` to types where missing
- added missing docstrings
- fixed type issues in `run_anomaly_for_kpi`
- renamed `end_date` to help type checker recognize correctly
- added an exception on `else:`
- added ignores to SQLalchemy filters where applicable
- added missing type annotations to `get_anomaly_count`
- formatted using `isort` and `black`
|
|
✅ Deploy Preview for frontend-sb canceled.
|
kartikay-bagla
suggested changes
Jun 7, 2022
Also made the exception better. Co-authored-by: Kartikay Bagla <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional[]to types where missingrun_anomaly_for_kpiend_dateto help type checker recognize correctlyelse:get_anomaly_countisortandblack