This repository has been archived by the owner on Sep 12, 2024. It is now read-only.
fix(datasource): use case-insensitive check for LIMIT #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for frontend-sb canceled.
|
Samyak2
force-pushed
the
fix/test-query-allow-limit
branch
from
87c5c0b to
156edfd
Compare
Before applying our own `LIMIT 1`, we check if the query already has a `LIMIT` clause by a simple substring search. This had two issues: - It did not work when `LIMIT` was in uppercase - It could match "limit" in a column or table name Changed this to use a case-insensitive regex search which also looks for whitespace around `LIMIT`. Since "limit" as a column or table name will need to enclosed in double quotes, this regex will not match them.
Samyak2
force-pushed
the
fix/test-query-allow-limit
branch
from
156edfd to
95e90c8
Compare
manassolanki
approved these changes
Sep 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before applying our own
LIMIT 1, we check if the query already has aLIMITclause by a simple substring search. This had two issues:LIMITwas in uppercaseChanged this to use a case-insensitive regex search which also looks for whitespace around
LIMIT. Since "limit" as a column or table name will need to enclosed in double quotes, this regex will not match them.