Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

feat(alerts): add CSV to email alert report, better CSV names #1035

Merged
merged 2 commits into from
Jul 15, 2022

Conversation

Samyak2
Copy link
Contributor

@Samyak2 Samyak2 commented Jul 13, 2022

Changes

  • Modify make_anomaly_data_csv to handle reports too
  • Make make_anomaly_data_csv a public function, to use it in base_alerts_digest.py
  • Modify make_anomaly_data_csv to take AnomalyPointFormatted to make it consistent with reports. Also changed creation of AlertsIndividualData to store AnomalyPointFormatted instead of AnomalyPoint.
  • Add better file name to individual alert CSV.
    • Change send_static_alert_email to not set the mime subtype same as the file name
    • Change send_static_alert_email to optionally take the MIME main and sub type
    • Change individual alert CSV dict to include MIME types and better name with KPI name and date
  • Add CSV to alert report, with correct MIME types and a nice name

@Samyak2 Samyak2 added 🛠️ backend ❗alerts Alert formatting, scheduling, etc. labels Jul 13, 2022
@Samyak2 Samyak2 added this to the v0.10.0 milestone Jul 13, 2022
@gitpod-io
Copy link

gitpod-io bot commented Jul 13, 2022

@netlify
Copy link

netlify bot commented Jul 13, 2022

Deploy Preview for frontend-sb canceled.

Name Link
🔨 Latest commit 5f074db
🔍 Latest deploy log https://app.netlify.com/sites/frontend-sb/deploys/62cfca07dc195a0008a5d98d

@Samyak2 Samyak2 force-pushed the feat/alert-report-csv branch from 81bf685 to b39cdba Compare July 14, 2022 05:33
@Samyak2 Samyak2 force-pushed the feat/alert-report-csv branch from b39cdba to a240a6f Compare July 14, 2022 05:35
@Samyak2 Samyak2 merged commit cd2f530 into develop Jul 15, 2022
@Samyak2 Samyak2 deleted the feat/alert-report-csv branch July 15, 2022 03:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
❗alerts Alert formatting, scheduling, etc. 🛠️ backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants