Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

fix(alerts-dashboard): consider only alert triggers with anomaly setup #1020

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

Samyak2
Copy link
Contributor

@Samyak2 Samyak2 commented Jul 4, 2022

This was causing an issue where if anomaly was manually disabled by
setting anomaly_params to NULL, getting the time series frequency
would fail.

This was causing an issue where if anomaly was manually disabled by
setting `anomaly_params` to NULL, getting the time series frequency
would fail.

This was not considered since disabling anomaly was not a feature that
was implemented.
@Samyak2 Samyak2 added 🐛 bug Something isn't working ❗alerts Alert formatting, scheduling, etc. labels Jul 4, 2022
@Samyak2 Samyak2 added this to the v0.10.0 milestone Jul 4, 2022
@Samyak2 Samyak2 requested a review from manassolanki July 4, 2022 06:27
@gitpod-io
Copy link

gitpod-io bot commented Jul 4, 2022

@netlify
Copy link

netlify bot commented Jul 4, 2022

Deploy Preview for frontend-sb canceled.

Name Link
🔨 Latest commit e138e65
🔍 Latest deploy log https://app.netlify.com/sites/frontend-sb/deploys/62c2883ac70ac70008b3f80d

@Samyak2 Samyak2 modified the milestones: v0.10.0, v0.9.1 Jul 6, 2022
@manassolanki
Copy link
Member

@Samyak2 I think let's also try to have some provision in the code for disabling/pausing the anomaly for a given KPI after running that for a few weeks without breaking/affecting things elsewhere.
Just give it a thought and let me know if we need to have changes at some other places as well.
cc: @varunp2k

@Samyak2
Copy link
Contributor Author

Samyak2 commented Jul 7, 2022

@manassolanki I have looked at a uses of anomaly_params throughout the codebase, everything seems fine - the only places where we have used it are either in anomaly, alerts (only in triggers - so it's only run along with anomaly) or anomaly_data_view (which is what sets anomaly_params).

We could add an endpoint to disable anomaly by setting the anomaly_params to None. There is a run_anomaly column in the kpi table, but that isn't being used anywhere. Maybe we should switch to that instead of relying on anomaly_params being None. This will be for v0.10.0, I'm merging this now.

@Samyak2 Samyak2 merged commit 0553fef into develop Jul 7, 2022
@Samyak2 Samyak2 deleted the fix/alerts-dashboard-anomaly-disabled branch July 7, 2022 09:43
@Samyak2 Samyak2 mentioned this pull request Jul 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
❗alerts Alert formatting, scheduling, etc. 🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants