Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

[BUG] No Error Shown in KPI Validation when datetime column is unparseable string. #991

Closed
kartikay-bagla opened this issue Jun 15, 2022 · 0 comments
Assignees
Labels
🐛 bug Something isn't working
Milestone

Comments

@kartikay-bagla
Copy link
Contributor

Describe the bug

During KPI definition, if we select the date column incorrectly, we get an Internal Server Error instead of a human readable error message.

Current behavior

No error is displayed, API response is a Internal Server Error with code 500.

Expected behavior

Error should be in the form of The datetime column is of the type object, use 'cast' to convert to datetime.

@kartikay-bagla kartikay-bagla added the 🐛 bug Something isn't working label Jun 15, 2022
@kartikay-bagla kartikay-bagla added this to the v0.9.0 milestone Jun 15, 2022
@kartikay-bagla kartikay-bagla self-assigned this Jun 15, 2022
@kartikay-bagla kartikay-bagla changed the title [BUG] [BUG] No Error Shown in KPI Validation when datetime column is unparseable string. Jun 15, 2022
kartikay-bagla added a commit that referenced this issue Jun 15, 2022
varunp2k added a commit that referenced this issue Jun 16, 2022
…-aware-bug

Fixes #991 by checking for validation sucess before running checks for tz-aware data
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant