fix: only log error when anomaly needs to run

`anomaly_task` will be None when anomaly doesn't need to run. We will still log an error in that case, when there's actually no error. Co-authored-by: Kartikay Bagla <[email protected]>
chaos-genius · Jan 17, 2022 · 917ded1 · 917ded1
1 parent 7eb64b5
commit 917ded1
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/chaos_genius/jobs/anomaly_tasks.py b/chaos_genius/jobs/anomaly_tasks.py
@@ -319,11 +319,12 @@ def queue_kpi_analytics(kpi_id: int, run_anomaly=True):
     else:
         rca_task.apply_async()
 
-        if anomaly_task is None:
-            logger.error(
-                "Not running anomaly since it is not configured or KPI "
-                "(%d) was not found.",
-                kpi_id,
-            )
-        else:
-            anomaly_task.apply_async()
+        if run_anomaly:
+            if anomaly_task is None:
+                logger.error(
+                    "Not running anomaly since it is not configured or KPI "
+                    "(%d) was not found.",
+                    kpi_id,
+                )
+            else:
+                anomaly_task.apply_async()