[Fix][Connector-V2] Fix mongodb cdc start up mode option values not r…

…ight (apache#6338)
chaorongzhi · Aug 21, 2024 · 88c2bd9 · 88c2bd9
1 parent b35626c
commit 88c2bd9
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/...va/org/apache/seatunnel/connectors/seatunnel/cdc/mongodb/config/MongodbSourceOptions.java b/...va/org/apache/seatunnel/connectors/seatunnel/cdc/mongodb/config/MongodbSourceOptions.java
@@ -241,8 +241,7 @@ public class MongodbSourceOptions extends SourceOptions {
             Options.key(SourceOptions.STARTUP_MODE_KEY)
                     .singleChoice(
                             StartupMode.class,
-                            Arrays.asList(
-                                    StartupMode.INITIAL, StartupMode.EARLIEST, StartupMode.LATEST))
+                            Arrays.asList(StartupMode.INITIAL, StartupMode.TIMESTAMP))
                     .defaultValue(StartupMode.INITIAL)
                     .withDescription(
                             "Optional startup mode for CDC source, valid enumerations are "

diff --git a/...nnector-cdc-mongodb/src/test/java/mongodb/source/MongodbIncrementalSourceFactoryTest.java b/...nnector-cdc-mongodb/src/test/java/mongodb/source/MongodbIncrementalSourceFactoryTest.java
@@ -17,14 +17,33 @@
 
 package mongodb.source;
 
+import org.apache.seatunnel.api.configuration.SingleChoiceOption;
+import org.apache.seatunnel.connectors.cdc.base.option.SourceOptions;
+import org.apache.seatunnel.connectors.cdc.base.option.StartupMode;
 import org.apache.seatunnel.connectors.seatunnel.cdc.mongodb.MongodbIncrementalSourceFactory;
 
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 
+import java.util.Arrays;
+
 public class MongodbIncrementalSourceFactoryTest {
     @Test
     public void testOptionRule() {
         Assertions.assertNotNull((new MongodbIncrementalSourceFactory()).optionRule());
     }
+
+    @Test
+    public void testWithUnsupportedStartUpMode() {
+        MongodbIncrementalSourceFactory mongodbIncrementalSourceFactory =
+                new MongodbIncrementalSourceFactory();
+        mongodbIncrementalSourceFactory.optionRule().getOptionalOptions().stream()
+                .filter((option) -> option.key().equals(SourceOptions.STARTUP_MODE_KEY))
+                .forEach(
+                        (option) -> {
+                            Assertions.assertIterableEquals(
+                                    Arrays.asList(StartupMode.INITIAL, StartupMode.TIMESTAMP),
+                                    ((SingleChoiceOption<StartupMode>) option).getOptionValues());
+                        });
+    }
 }