Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add more constants (Unit and Quantity format) #83

Merged
merged 4 commits into from
Dec 25, 2024
Merged

Conversation

Routhleck
Copy link
Collaborator

@Routhleck Routhleck commented Dec 22, 2024

This pull request includes several significant changes to the brainunit package, focusing on the removal of unnecessary imports, the addition of new unit constants, and the improvement of unit tests. The most important changes are summarized below:

Removal of Unnecessary Imports:

Addition of New Unit Constants:

Improvements to Constants:

Unit Test Enhancements:

  • brainunit/constants_test.py: Introduced a comprehensive list of constants and added a new test to ensure consistency between quantity_constants and unit_constants. [1] [2]

Code Cleanup:

@Routhleck Routhleck changed the title [feat] Add more constants (Unit) [feat] Add more constants (Unit and Quantity format) Dec 22, 2024
@Routhleck Routhleck marked this pull request as ready for review December 22, 2024 04:06
Copy link
Collaborator

@chaoming0625 chaoming0625 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

@chaoming0625 chaoming0625 merged commit e818e55 into main Dec 25, 2024
24 checks passed
@chaoming0625 chaoming0625 deleted the constants branch December 25, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants