Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove factorless temporarily #79

Merged
merged 2 commits into from
Dec 12, 2024
Merged

remove factorless temporarily #79

merged 2 commits into from
Dec 12, 2024

Conversation

chaoming0625
Copy link
Collaborator

This pull request includes changes to the brainunit/_base.py file, primarily focusing on commenting out the factorless() method calls across various functions and methods. This adjustment aims to simplify the code by removing the need to strip units from Quantity objects before performing operations.

Key changes include:

Code Simplification:

  • Commented out factorless() method calls in functions that wrap other functions, such as _wrap_function_keep_unit, _wrap_function_change_unit, and _wrap_function_remove_unit. [1] [2] [3]

  • Commented out factorless() method calls in property methods like imag, real, and T. [1] [2]

  • Commented out factorless() method calls in various mathematical and array manipulation methods such as scatter_add, scatter_mul, scatter_div, scatter_max, scatter_min, and __len__. [1] [2] [3] [4] [5] [6]

  • Commented out factorless() method calls in various arithmetic and bitwise operation methods such as __pow__, __rpow__, __lshift__, __rlshift__, __ilshift__, __rshift__, __rrshift__, __irshift__, __round__, round, astype, clip, conj, conjugate, copy, dot, fill, flatten, item, prod, nanprod, cumprod, nancumprod, put, repeat, reshape, resize, sort, squeeze, swapaxes, split, and take. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17]

@chaoming0625 chaoming0625 merged commit 0109799 into main Dec 12, 2024
24 checks passed
@chaoming0625 chaoming0625 deleted the update branch December 12, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant