[breaking] Use fixed filepath to prevent spurious diffs

pkg/provider/data_lambda.go

@@ -57,13 +57,14 @@ func Lambda() *schema.Resource {
 				Description: "The kmsauth key ID",
 				ForceNew:    true,
 			},
-
-			// computed
 			SchemaOutputPath: &schema.Schema{
 				Type:        schema.TypeString,
-				Computed:    true,
+				Required:    true,
 				Description: "Temporary directory that holds the bless zip",
+				ForceNew:    true,
 			},
+
+			// computed
 			SchemaOutputBase64Sha256: &schema.Schema{
 				Type:        schema.TypeString,
 				Computed:    true,
@@ -146,9 +147,10 @@ func (l *resourceLambda) getBlessConfig(d *schema.ResourceData) (io.Reader, os.F
 
 // Create bundles the lambda code and configuration into a zip that can be uploaded to AWS lambda
 func (l *resourceLambda) Read(d *schema.ResourceData, meta interface{}) error {
-	outFile, err := ioutil.TempFile("", "bless.zip")
+	path:= d.Get(SchemaOutputPath).(string)
+	outFile, err := os.Create(path)
 	if err != nil {
-		return errors.Wrap(err, "Could not open temporary file")
+		return errors.Wrapf(err, "Could not open output file at %s", path)
 	}
 	defer outFile.Close()
 	writer := zip.NewWriter(outFile)
@@ -168,7 +170,6 @@ func (l *resourceLambda) Read(d *schema.ResourceData, meta interface{}) error {
 	if err != nil {
 		return err
 	}
-
 	// Write the config
 	err = l.writeFileToZip(blessConfig, blessConfigFileInfo, writer, "bless_deploy.cfg")
 	if err != nil {
@@ -181,7 +182,6 @@ func (l *resourceLambda) Read(d *schema.ResourceData, meta interface{}) error {
 		return err
 	}
 
-	d.Set(SchemaOutputPath, outFile.Name())
 	d.Set(SchemaOutputBase64Sha256, fileHash)
 	d.SetId(fileHash)
 	return err

pkg/provider/data_lambda_test.go

@@ -28,24 +28,19 @@ func TestLambdaCreate(t *testing.T) {
 					encrypted_password = "bbbb"
 					service_name = "test"
 					kmsauth_key_id = "keyID"
-
-				}
-
-				output "output_path" {
-					value = "${data.bless_lambda.zip.output_path}"
+					output_path = "/tmp/test"
 				}
 
 				output "output_base64sha256" {
 					value = "${data.bless_lambda.zip.output_base64sha256}"
 				}
 				`,
 				Check: func(s *terraform.State) error {
-					outputPath := s.RootModule().Outputs[provider.SchemaOutputPath].Value
 					base64sha256 := s.RootModule().Outputs[provider.SchemaOutputBase64Sha256].Value
-					a.NotEmpty(outputPath)
 					a.NotEmpty(base64sha256)
 					return nil
 				},
+				Destroy: true,
 			},
 		},
 	})