Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Newsletter Banner #601

Merged
merged 9 commits into from
Jul 6, 2023
Merged

feat: Newsletter Banner #601

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a63e37c
feat: Newsletter Banner
ashin-czi May 3, 2023
e4663d1
cleanup
ashin-czi May 3, 2023
9830326
indenting
ashin-czi May 3, 2023
f1c884f
comment
ashin-czi May 3, 2023
c870aef
cleanup
ashin-czi May 3, 2023
63a8fea
analytics
ashin-czi May 3, 2023
a978567
Merge branch 'main' into ashin-czi/newsletter-banner
ashin-czi Jun 12, 2023
8796a26
Merge branch 'main' into ashin-czi/newsletter-banner
ashin-czi Jul 6, 2023
e1fb3ef
moving script injection for hubspot js
ashin-czi Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions client/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,13 @@
/>
</head>
<body>

<script
id="hubspot-js"
type="text/javascript"
src="https://js.hsforms.net/forms/v2.js"
></script>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to use Hubspot's JS file to embed their form and submit the email to their API


<script type="text/javascript">
window.CELLXGENE = {};
window.CELLXGENE.API = {
Expand Down
8 changes: 7 additions & 1 deletion client/src/analytics/events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,5 +51,11 @@ export enum EVENTS {
WMG_CLICK_NAV = "WMG_CLICK_NAV",
COLLECTIONS_CLICK_NAV = "COLLECTIONS_CLICK_NAV",
DATASETS_CLICK_NAV = "DATASETS_CLICK_NAV",
DOCUMENTATION_CLICK_NAV = "DOCUMENTATION_CLICK_NAV"
DOCUMENTATION_CLICK_NAV = "DOCUMENTATION_CLICK_NAV",
NEWSLETTER_EMAIL_SUBMITTED = "NEWSLETTER_EMAIL_SUBMITTED",
NEWSLETTER_SIGNUP_SUCCESS = "NEWSLETTER_SIGNUP_SUCCESS",
NEWSLETTER_SIGNUP_FAILURE = "NEWSLETTER_SIGNUP_FAILURE",
NEWSLETTER_OPEN_MODAL_CLICKED = "NEWSLETTER_OPEN_MODAL_CLICKED",
NEWSLETTER_DIRECT_LINK_NAVIGATED = "NEWSLETTER_DIRECT_LINK_NAVIGATED",
NEWSLETTER_SUBSCRIBE_BUTTON_AVAILABLE = "NEWSLETTER_SUBSCRIBE_BUTTON_AVAILABLE",
}
4 changes: 0 additions & 4 deletions client/src/components/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { StylesProvider, ThemeProvider } from "@material-ui/core/styles";
import { theme } from "./theme";

import Controls from "./controls";
import DatasetSelector from "./datasetSelector/datasetSelector";
import Container from "./framework/container";
import Layout from "./framework/layout";
import LayoutSkeleton from "./framework/layoutSkeleton";
Expand Down Expand Up @@ -96,9 +95,6 @@ class App extends React.Component<Props> {
viewportRef={viewportRef}
key={graphRenderCounter}
/>
<Controls bottom={0}>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're moving the breadcrumbs into the component for finer control of the styling based on if the banner is open or not

<DatasetSelector />
</Controls>
</>
)}
>
Expand Down
10 changes: 10 additions & 0 deletions client/src/components/bottomBanner/CellxGene.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading